-Fixing and clean code

.idea/gradle.xml

@@ -1,15 +1,20 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project version="4">
+  <component name="GradleMigrationSettings" migrationVersion="1" />
   <component name="GradleSettings">
     <option name="linkedExternalProjectsSettings">
       <GradleProjectSettings>
-        <compositeConfiguration>
-          <compositeBuild compositeDefinitionSource="SCRIPT" />
-        </compositeConfiguration>
+        <option name="delegatedBuild" value="false" />
+        <option name="testRunner" value="PLATFORM" />
         <option name="distributionType" value="DEFAULT_WRAPPED" />
         <option name="externalProjectPath" value="$PROJECT_DIR$" />
+        <option name="modules">
+          <set>
+            <option value="$PROJECT_DIR$" />
+            <option value="$PROJECT_DIR$/app" />
+          </set>
+        </option>
         <option name="resolveModulePerSourceSet" value="false" />
-        <option name="testRunner" value="PLATFORM" />
       </GradleProjectSettings>
     </option>
   </component>

app/build.gradle

@@ -4,7 +4,7 @@ apply from: '../config/git-version.gradle'
 
 android {
     compileSdkVersion 29
-    buildToolsVersion "29.0.2"
+    buildToolsVersion "29.0.3"
     defaultConfig {
         applicationId "com.fusi24.rfid"
         minSdkVersion 21
@@ -62,18 +62,18 @@ dependencies {
     implementation 'com.squareup.retrofit2:converter-gson:2.6.0'
 
     //Circle Image
-    implementation 'de.hdodenhof:circleimageview:3.0.0'
+    implementation 'de.hdodenhof:circleimageview:3.1.0'
 
     //Glide Image Processing
-    implementation 'com.github.bumptech.glide:glide:4.10.0'
-    annotationProcessor 'com.github.bumptech.glide:compiler:4.10.0'
+    implementation 'com.github.bumptech.glide:glide:4.11.0'
+    annotationProcessor 'com.github.bumptech.glide:compiler:4.11.0'
 
     //Serial Port
     implementation files('libs/serialport.jar')
     implementation files('libs/android-async-http-1.4.9.jar')
     implementation files('libs/httpclient-4.4.1.1.jar')
 
-    testImplementation 'junit:junit:4.12'
+    testImplementation 'junit:junit:4.13'
     androidTestImplementation 'androidx.test.ext:junit:1.1.1'
     androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
 }

app/src/main/AndroidManifest.xml

@@ -11,9 +11,11 @@
         android:roundIcon="@drawable/logo_hse_autimation"
         android:supportsRtl="true"
         android:theme="@style/AppTheme">
-        <activity android:name=".ui.scanresult.ScanResultActivity"></activity>
+        <activity android:name=".ui.scanresult.ScanResultActivity"
+            android:screenOrientation="fullSensor"/>
         <activity
             android:name=".MainActivity"
+            android:screenOrientation="fullSensor"
             android:theme="@style/Theme.AppCompat.Light.NoActionBar">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />
@@ -21,7 +23,8 @@
                 <category android:name="android.intent.category.LAUNCHER" />
             </intent-filter>
         </activity>
-        <activity android:name=".ui.ScanActivity" />
+        <activity android:name=".ui.ScanActivity"
+            android:screenOrientation="fullSensor"/>
     </application>
 
 </manifest>

app/src/main/java/com/fusi24/rfid/MainActivity.java

@@ -27,6 +27,7 @@ import butterknife.ButterKnife;
 import retrofit2.Call;
 import retrofit2.Callback;
 import retrofit2.Response;
+import timber.log.Timber;
 
 public class MainActivity extends BaseActivity {
 
@@ -99,6 +100,7 @@ public class MainActivity extends BaseActivity {
             @Override
             public void onFailure(@NotNull Call<List<DataEntryPermit>> call, @NotNull Throwable t) {
                 Toast.makeText(MainActivity.this, "Failed to get data permit", Toast.LENGTH_SHORT).show();
+                Timber.i("DEVELOPER : %s", t.getMessage());
             }
         });
     }

app/src/main/java/com/fusi24/rfid/adapter/ScanResultAdapter.java

@@ -37,7 +37,7 @@ public class ScanResultAdapter extends RecyclerView.Adapter<ScanResultAdapter.Vi
         setProblemsList(problemsList);
     }
 
-    class ViewHolder extends RecyclerView.ViewHolder {
+    static class ViewHolder extends RecyclerView.ViewHolder {
 
         @BindView(R.id.tv_document_name)
         TextView tvDocumentName;

app/src/main/java/com/fusi24/rfid/config/Constant.java

@@ -20,7 +20,7 @@ public final class Constant {
     /*===================================================================================================*/
 
     //Direct ke BCUI
-    public final static String BASE_URL = "http://bcui2.fusi24.com";
+    /*public final static String BASE_URL = "http://bcui2.fusi24.com";
 
     public final static String BEATS_ENDPOINT = "/beats";
     public final static String BEATS2_ENDPOINT = "/beats2";
@@ -28,10 +28,10 @@ public final class Constant {
     public final static String SID2_ENDPOINT = "/sid2";
     public final static String RFID_ENDPOINT = "/rfid";
 
-    public static final String URL_PHOTO = BASE_URL + BEATS2_ENDPOINT + "/file?path=";
+    public static final String URL_PHOTO = BASE_URL + BEATS2_ENDPOINT + "/file?path=";*/
 
     //Direct ke Production
-    /*public final static String BASE_URL = "http://hseautomation.beraucoal.co.id";
+    public final static String BASE_URL = "http://hseautomation.beraucoal.co.id";
 
     public final static String BEATS_ENDPOINT = "/beats";
     public final static String BEATS2_ENDPOINT = "/beats2";
@@ -39,7 +39,7 @@ public final class Constant {
     public final static String SID2_ENDPOINT = "/sid2";
     public final static String RFID_ENDPOINT = "/rfid";
 
-    public static final String URL_PHOTO = BASE_URL + BEATS2_ENDPOINT + "/file?path=";*/
+    public static final String URL_PHOTO = BASE_URL + BEATS2_ENDPOINT + "/file?path=";
 
     /*===================================================================================================*/
 

app/src/main/java/com/fusi24/rfid/data/api/RestServiceFactory.java

@@ -24,7 +24,6 @@ public class RestServiceFactory {
     private static RestService makeRestService(OkHttpClient okHttp, Gson gson) {
 
         Retrofit retrofit = new Retrofit.Builder()
-                //.baseUrl(Constant.BASE_URL)
                 .baseUrl(Constant.BASE_URL)
                 .client(okHttp)
                 .addConverterFactory(GsonConverterFactory.create(gson))

app/src/main/java/com/fusi24/rfid/data/entity/DataCommon.java

@@ -1,36 +0,0 @@
-package com.fusi24.rfid.data.entity;
-
-import org.jetbrains.annotations.NotNull;
-
-public class DataCommon {
-
-    private Integer id;
-    private String name;
-
-    public DataCommon(Integer id, String name) {
-        this.id = id;
-        this.name = name;
-    }
-
-    public Integer getId() {
-        return id;
-    }
-
-    public void setId(Integer id) {
-        this.id = id;
-    }
-
-    public String getName() {
-        return name;
-    }
-
-    public void setName(String name) {
-        this.name = name;
-    }
-
-    @NotNull
-    @Override
-    public String toString() {
-        return name;
-    }
-}

app/src/main/java/com/fusi24/rfid/ui/ScanActivity.java

@@ -56,6 +56,7 @@ public class ScanActivity extends LFScanProcessing {
         startActivityForResult(intent, 1);
     }
 
+    // This method for read chip number in the card
     @Override
     protected void onDataReceived(byte[] buffer, int size) {
         runOnUiThread(() -> {

gradle/wrapper/gradle-wrapper.properties

@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-all.zip